Re: [PATCH] compat: expose canonicalize_file_name to C++

Subject: Re: [PATCH] compat: expose canonicalize_file_name to C++

Date: Sat, 17 Apr 2021 11:39:59 -0300

To: Đoàn Trần Công Danh


From: David Bremner

Đoàn Trần Công Danh <> writes:

> However, I see that lib/ uses g_key_file_get_value from GLib
> already, we may switch to g_canonicalize_file_name then?

Yes that could work. I think the treatment of NULL input might need some
extra care with g_canonicalize_file_name; at least my 5 minute attempt
to do a replacement causes many test failures. Do you want to make a
patch that uses g_canonicalize_file_name? The one other place we use
canonicalize_file_name (not totally coincidentally) also uses glib, so
in principle we could completely eliminate the compat function.

notmuch mailing list --
To unsubscribe send an email to