Re: [PATCH] Add a few tests for searching LWN emails.

Subject: Re: [PATCH] Add a few tests for searching LWN emails.

Date: Sun, 30 Jan 2011 12:01:47 +0100

To: Carl Worth, notmuch@notmuchmail.org

Cc:

From: Thomas Schwinge


Hallo!

On Sat, 29 Jan 2011 05:59:38 +1000, Carl Worth <cworth@cworth.org> wrote:
> On Thu, 27 Jan 2011 03:31:49 -0700, Thomas Schwinge <thomas@schwinge.name> wrote:
> > These tests should pass -- but they currently don't.

> Thanks for sending these test cases. This is actually my favorite way to
> receive bug reports. I really appreciate it!

I'm doing this for a simple resons: I won't manually have to remember (!)
and later re-run my testings in order to confirm that the issue has been
fixed.  :-)


> So I'm not sure what could reasonably be changed here in GMime or not. I
> definitely do want to fix notmuch so that it indexes all of the text
> here regardless if it's formatted in an RFC-compliant way or not.

Given Matthieu's comment, I wouldn't; as I explained in my reply to his
email.  Now, if this is indeed a GMIME issue -- do we want these tests in
notmuch at all, or should I rather (adapt and) submit them for GMIME?


> [*] Except for test VI which has a bug in that it searches for the word
> "mailing" in the subject header, but no such word exists in the
> message's subject header.

Ack.  Fixed locally.


Grüße,
 Thomas
part-000.sig (application/pgp-signature)

Thread: