Re: [PATCH] devel: add release-checks.sh

Subject: Re: [PATCH] devel: add release-checks.sh

Date: Sun, 19 Aug 2012 16:03:03 +0200

To: Tomi Ollila, notmuch@notmuchmail.org

Cc:

From: David Bremner


Tomi Ollila <tomi.ollila@iki.fi> writes:

> Currently Makefile.local contains some machine executable release
> checking functionality. This is unnecessarily complex way to do it:

Hi Tomi;

Overall this looks good, but there seems to be one minor bug:

- If there are extra files under man/man1 (e.g. from "make
  update-versions"), then the check "Checking that manual page dates and
  versions" fails, even if it passes after running "git clean -fx"

I don't really think this is a blocker, but on the other hand it isn't
urgent to ship the patch either.

Another piece of Makefile.local that isn't really "make" is
"update-versions". On the other hand, it isn't nearly as long or
complicated as the release checks.

d

Thread: