Re: [PATCH] CLI/git: use --exclude=false when calling notmuch-search

Subject: Re: [PATCH] CLI/git: use --exclude=false when calling notmuch-search

Date: Tue, 27 Dec 2022 11:58:53 -0400

To: notmuch@notmuchmail.org

Cc:

From: David Bremner


David Bremner <david@tethera.net> writes:

> We use notmuch search in two places in notmuch-git.py: to find which
> tags have a given prefix, and to see if message with given id exists
> locally. In both cases we do not want the presence of exclude tags
> (e.g. deleted) to change the results.
> ---
>  notmuch-git.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> The effects of this bug are a bit subtle; out of 12324 messages tagged
> 'deleted', without this fix I was missing 25 messages. That probably
> explains why I couldn't come up with a test to demonstrate the
> issue. On other hand, I think it is pretty clearly the right thing to
> do, even if most people don't notice a change.

applied to master.

d
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: