On 2025-03-04 19:46, Michael Albinus wrote:

> Nicolas Graves <ngraves@ngraves.fr> writes:
>
> Hi Nicolas,
>
>> Attached you can find a file with a minor mode that does just that and
>> damn it's so much better to work with debbugs now.
>
> Nice.
>
>> I don't know however in which package I should rather upstream the
>> content of this. Could be :
>>
>> - In debbugs, by creating a proper debbugs-gnu-mail-backend that would
>> only be defined if notmuch is present, or by copying the way piem
>> uses variables to store functions instead of having an inflexible
>> debbugs-gnu-mail-backend and hardcoding the rest from there.
>
> I wouldn't mind to add it to the debbugs package. An advantage would
> be, that it will be documented in the User Guide.
>
> However, debbugs is located in the GNU ELPA archive, which means it must
> be copyrighted to the FSF. Would you agree to sign such legal
> paperwork?

Not an issue for me in principle, I just hope it's not too
time-consuming.

> [...]

Thanks for the quick review.

> This might be a problem when adding to the debbugs package. It requires
> Emacs 26.1. How strong is the dependency from Emacs 28.1?

None, I'll remove that as well as most of your previous comments.

>> (defgroup debbugs-notmuch nil
>>   "Notmuch integration for debbugs."
>>   :group 'debbugs
>>   :group 'notmuch)
>
> What is it good for? AFAICS, you don't have user options or faces, which
> could go there. And even if you would have, they could live in the
> `debbugs' group.

Yep 

> What I do miss is the intehration of debbugs-gnu-send-control-message
> and debbugs-gnu-make-control-message into notmuch. Do you plan this?

Actually I think that would be great, but that there's a need to
reorganize the "backend" part of debbugs much more like piem, so that
the backend can be configured "outside" of debbugs too.

In piem it's quite elegant, there are four configurable functions, and a
few modes to adjust them.  In debbugs it could look like 3 minor modes
(rmail, gnus, notmuch) which each set a few variables when triggered
(debbugs-gnu-select-current-bugs-function,
debbugs-gnu-read-emacs-bug-function + possibly / if useful
debbugs-gnu-send-control-message-function,
debbugs-gnu-make-control-message-function, or other functions that are
dependent on debbugs-gnu-mail-backends in debbugs-gnu.el)
instead of have the variable debbugs-gnu-mail-backend)

(define-minor-mode debbugs-gnus-mode
  "Toggle Gnus support for debbugs.
With a prefix argument ARG, enable piem-gnus mode if ARG is
positive, and disable it otherwise.  If called from Lisp, enable
the mode if ARG is omitted or nil."
  :global t
  :init-value nil
  (if debbugs-gnus-mode
      (setopt debbugs-gnu-select-report-function
              #'debbugs-gnu-read-emacs-bug-with-gnus)
      (setopt ...)))

(define-minor-mode debbugs-rmail-mode ...)
(define-minor-mode debbugs-notmuch-mode
 [...]
 (if debbugs-notmuch-mode
     (if (require 'notmuch nil t)
       (setopt ...)
       (error "notmuch is required to run trigger debbugs-notmuch-mode")
     (if (require 'notmuch nil t)
       (setopt ...)
       (error "notmuch is required to run trigger debbugs-notmuch-mode"))

And arrange to have gnus as a default.

I find that quite relevant ; IMO it would allow a more flexible addition
of additional backends.

In the case of piem multiple modes add functions, in debbugs' case it's
more about replacing them, so setopt instead of add-hook/remove-hook.
Looks OK to implement.

WDYT ?

-- 
Best regards,
Nicolas Graves
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org