Re: [PATCH] notmuch-dev: Forcibly delete branches.

Subject: Re: [PATCH] notmuch-dev: Forcibly delete branches.

Date: Fri, 13 Jan 2012 08:25:32 -0400

To: David Edmondson, notmuch@notmuchmail.org

Cc:

From: David Bremner


On Fri, 13 Jan 2012 10:25:29 +0000, David Edmondson <dme@dme.org> wrote:
> `magit-delete-branch' runs "git branch -d <branch>", which refuses to
> delete branches that are not fully merged. Given that we don't care
> and don't want to be stalled, use "git branch -D <branch>" directly.
> ---

Yes, that seems to fix it. 

Two more questions/comments.

- Should n-d-s-review-patch update to current master? perhaps with
  prefix?

- I think more escaping of branch names is needed. In particular, branch
  names with {} in them get created ok, but then don't work very well in
  magit.  E.g. running log I get "Args out of range: "face}s", 5, 10"
  with the branch name

       review/patch-v2-emacs-logically-group-def{custom,face}s

d

Thread: