Re: [PATCH] Avoid empty thread names if possible.

Subject: Re: [PATCH] Avoid empty thread names if possible.

Date: Wed, 29 Oct 2014 09:21:52 -0400

To: Tomi Ollila, notmuch@notmuchmail.org

Cc:

From: Jesse Rosenthal

Thanks for taking a look.

Tomi Ollila <tomi.ollila@iki.fi> writes:

> IMO it is a bit silly to scan through the whole string and use the return
> value of 0 (vs != 0) to have effect. we should probably have something like
> #define EMPTY_STRING(s) ((s)[0] == '\0') 
> and use that instead.

Good point. Will put in the next version.

> Also, to keep promise, mentioning 'patch' in commit message referring to 
> the change introduced does IMO also look silly :D

Ah. Yep, agreed.

Thread: