Re: [PATCH v2] emacs: Add notmuch-update-search-tags

Subject: Re: [PATCH v2] emacs: Add notmuch-update-search-tags

Date: Mon, 28 Aug 2017 22:18:03 -0300

To: Vladimir Panteleev,


From: David Bremner

Vladimir Panteleev <> writes:

>  Speaking of which, I had a fun time trying to figure out why my test
>  didn't work before I discovered that notmuch-tag-deleted-formats is
>  reset in test-lib.el. That took quite a bit of debugging; I think it
>  would be good to fix this inconsistency to avoid other contributors
>  wasting time on this in the future.

Yes, I think you're probably right, although I haven't looked at the
resulting work to update all of relevant tests. There's probably a few
other places where we've accumulated "technical debt" by doing the easy
thing in the test suite.

Maybe I'm overthinking this, but it seems like we'd need some way to
recognize various faces. There is a package called faceup that is
targeted at roughly this problem.  I know that racket-mode uses it to
test highlighting. Perhaps that's an dependancy we can tolerate for the
test suite, at least optionally. Or perhaps some simpler approach can
work since we can choose the faces as well.

notmuch mailing list