Re: [PATCH v4] python: add decrypt_policy argument to Database.index_file()

Subject: Re: [PATCH v4] python: add decrypt_policy argument to Database.index_file()

Date: Tue, 19 Dec 2017 14:08:15 -0500

To: David Bremner, Notmuch Mail

Cc:

From: Daniel Kahn Gillmor

On Tue 2017-12-19 07:23:35 -0400, David Bremner wrote:
> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
>
>> +Date: $(date -R)
>> +Message-ID: <simplemsg@crypto.notmuchmail.org>
>> +MIME-Version: 1.0
>> +Content-Type: multipart/encrypted; boundary="=-=-=";
>> +	protocol="application/pgp-encrypted"
>> +
>
> Can you explain why you explicitely set the date here? it seems to make
> the test less reproducible. In the end it doesn't matter much because
> your test ignores the date, but I feel like I'm missing something.

There's no good reason for setting it explicitly to "now" in this test.
I'll send a revised patch with a static datestring.

Sorry for the distraction!

        --dkg

_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

• Previous message (by thread): Re: [PATCH v5] python: add decrypt_policy argument to Database.index_file()

Thread:

• Daniel Kahn Gillmor—session keys followup, version 3 [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v3 01/15] indexing: Change from try_decrypt to decrypt [inbox, notmuch::patch, notmuch::pushed, unread]
  • Daniel Kahn Gillmor—[PATCH v3 02/15] indexopts: change _try_decrypt to _decrypt_policy [inbox, notmuch::patch, notmuch::pushed, unread]
  • Daniel Kahn Gillmor—[PATCH v3 03/15] lib: convert notmuch decryption policy to an enum [inbox, notmuch::patch, notmuch::pushed, unread]
  • Daniel Kahn Gillmor—[PATCH v3 04/15] crypto: new decryption policy "auto" [inbox, notmuch::patch, notmuch::pushed, unread]
  • Daniel Kahn Gillmor—[PATCH v3 05/15] cli/reply: use decryption policy "auto" by default. [inbox, notmuch::patch, notmuch::pushed, unread]
  • Daniel Kahn Gillmor—[PATCH v3 06/15] cli/show: use decryption policy "auto" by default. [inbox, notmuch::patch, notmuch::pushed, unread]
  • Daniel Kahn Gillmor—[PATCH v3 07/15] cli/show, reply: document use of stashed session keys in notmuch-properties [inbox, notmuch::patch, notmuch::pushed, unread]
  • Daniel Kahn Gillmor—[PATCH v3 08/15] cli/new, insert, reindex: update documentation for --decrypt=auto [inbox, notmuch::patch, notmuch::pushed, unread]
  • Daniel Kahn Gillmor—[PATCH v3 09/15] crypto: record whether an actual decryption attempt happened [inbox, notmuch::patch, notmuch::pushed, unread]
  • Daniel Kahn Gillmor—[PATCH v3 10/15] cli/new, insert, reindex: change index.decrypt to "auto" by default [inbox, notmuch::patch, notmuch::pushed, unread]
  • Daniel Kahn Gillmor—[PATCH v3 11/15] cli/reindex: destroy stashed session keys when --decrypt=false [inbox, notmuch::patch, notmuch::pushed, unread]
  • Daniel Kahn Gillmor—[PATCH v3 12/15] crypto: actually stash session keys when decrypt=true [inbox, notmuch::patch, notmuch::pushed, unread]
  • Daniel Kahn Gillmor—[PATCH v3 13/15] crypto: add --decrypt=nostash to avoid stashing session keys [inbox, notmuch::patch, notmuch::pushed, unread]
  • Daniel Kahn Gillmor—[PATCH v3 14/15] docs: clean up documentation about decryption policies [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH v3 14/15] docs: clean up documentation about decryption policies [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH v3 14/15] docs: clean up documentation about decryption policies [inbox, signed, unread]
  • Daniel Kahn Gillmor—[PATCH v3 15/15] python: add decrypt_policy argument to Database.index_file() [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Daniel Kahn Gillmor—[PATCH v4] python: add decrypt_policy argument to Database.index_file() [inbox, notmuch::obsolete, notmuch::patch, unread]
      • David Bremner—Re: [PATCH v4] python: add decrypt_policy argument to Database.index_file() [inbox, unread]
        • Daniel Kahn Gillmor—Re: [PATCH v4] python: add decrypt_policy argument to Database.index_file() [inbox, signed, unread]
      • Daniel Kahn Gillmor—[PATCH v5] python: add decrypt_policy argument to Database.index_file() [inbox, notmuch::0.26, notmuch::patch, notmuch::pushed, unread]
        • David Bremner—Re: [PATCH v5] python: add decrypt_policy argument to Database.index_file() [inbox, unread]