Re: [PATCH] util/zlib-extra: de-inline gzerror_str

Subject: Re: [PATCH] util/zlib-extra: de-inline gzerror_str

Date: Tue, 28 Apr 2020 10:38:24 -0300



From: David Bremner

David Bremner <> writes:

> It turns out the behaviour of inline functions in C header files is
> not a good idea, and can cause linking problems if the compiler
> decides not to inline them.  In principle this is solvable by using a
> "static inline" declaration, but this potentially makes a copy in
> every compilation unit. Since we don't actually care about the
> performance of this function, just use a non-inline function.

pushed to master, with slightly tweaked commit message

notmuch mailing list