Re: [PATCH v2] open: avoid leaking index_as_text regex objects

Subject: Re: [PATCH v2] open: avoid leaking index_as_text regex objects

Date: Sun, 09 Nov 2025 08:10:46 -0400

To: Anton Khirnov

Cc: notmuch@notmuchmail.org

From: David Bremner


Anton Khirnov <anton@khirnov.net> writes:

> Regexes compiled with regcomp() need to be freed with regfree(). Do that
> in a talloc destructor attached to the compiled regex array.

Applied, with a couple of style tweaks. It is a bit unusual, but even in
C++ files we use C comments. I guess because Carl originally wanted to
pretend there was no C++ ;).

d

P.S. Apologies, I have very little time for notmuch (or anything other
than work) at the moment, so I haven't had a chance to look at the other
series.
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: