Hi, Felix. Thanks for resubmitting these patches. A couple more comments: Remember to include a longer log message with you patch. Beyond just the single line commit message, the patch should also include a longer commit message, separated from the first line by a blank line, that explains what exactly the patch is doing and why. We've also been trying to get in the habit of sending patches to the test suite *first*, before the patch that actually implements the change. The reason being that we can apply the test-suite patch first, see that the feature or bug fix you're trying to implement is not implemented, then apply the fix and see that everything is working again. Now is probably a good time to remind everyone to look at the GIT patch submission guidlines, which notmuch has been trying to follow (also linked from http://notmuchmail.org): http://repo.or.cz/w/git.git?a=blob;f=Documentation/SubmittingPatches;hb=HEAD jamie.