Re: [PATCH] Return maximum of 150 results

Subject: Re: [PATCH] Return maximum of 150 results

Date: Tue, 23 Aug 2011 01:46:00 +0200

To: James Vasile, Michal Sojka, notmuch@notmuchmail.org

Cc:

From: Daniel Schoepe


On Sat, 20 Aug 2011 15:11:00 -0400, James Vasile <james@hackervisions.org> wrote:
> On Fri, 19 Aug 2011 17:00:23 +0200, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
> > If you really want this behavior, I propose to make the default value
> > of notmuch-max-results infinity.
> 
> I'm attaching a revised patch that does as you suggest.  Thanks.

I think this is a nice feature.

> +(defvar notmuch-max-results 0)

This should probably be a defcustom and it also needs a docstring
(saying, along with a general description, that 0 means "show all
messages"). Changing it so that nil means all messages might be a bit
nicer (since nil says "no maximum number of results" more clearly, I
think) though, but that's probably just me nitpicking.

Cheers,
Daniel
part-000.sig (application/pgp-signature)

Thread: