Re: [PATCH v2 0/5] emacs: notmuch-hello status message refresh hook, etc

Subject: Re: [PATCH v2 0/5] emacs: notmuch-hello status message refresh hook, etc

Date: Tue, 04 Sep 2012 19:11:19 +0200

To: Jani Nikula, notmuch@notmuchmail.org

Cc:

From: Michal Sojka


On Sun, Sep 02 2012, Jani Nikula wrote:
> Hi all, v2 of [1] addressing review comments: added NEWS, improved
> documentation, made the query customizable.
>
> [1]
>     id:"37899e28dbf67e4620a53279a869be3174c02d6f.1339775602.git.jani@nikula.org"

Hello Jani,

if I understand correctly, the goal of this patchset is to display the
message with the difference in the number of messages before and after
refresh of notmuch-hello.

I think the current implementation is unnecessarily complicated. It
would be sufficient to implement this directly in `notmuch-hello'
without any hook. If `notmuch-hello-refresh-status-query' is nil
(default) no message would be shown. If it is configured to something
else, the message would be shown provided that no-display is nil. This
way you don't have to break existing user's hooks and achieve the same
behavior, don't you?

-Michal

Thread: