Re: [PATCH 6/6] cli: add top level --config=FILE option

Subject: Re: [PATCH 6/6] cli: add top level --config=FILE option

Date: Sun, 03 Mar 2013 12:32:31 -0400

To: Jani Nikula, notmuch@notmuchmail.org

Cc:

From: David Bremner

Jani Nikula <jani@nikula.org> writes:

> Let the user specify the config file on the command line.
>  
> -    config = notmuch_config_open (local, NULL, command->create_config);
> +    config = notmuch_config_open (local, config_file_name, command->create_config);
>      if (!config)
>  	return 1;

LGTM

• Previous message (by thread): Re: [PATCH 0/6] notmuch cli config changes

Thread:

• Jani Nikula—[PATCH 0/6] notmuch cli config changes [inbox, unread]
  • Jani Nikula—[PATCH 1/6] cli: keep track of whether the config is newly created [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH 1/6] cli: keep track of whether the config is newly created [inbox, notmuch::review, unread]
  • Jani Nikula—[PATCH 2/6] cli: make notmuch_config_open() "is new" parameter input only [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH 2/6] cli: make notmuch_config_open() "is new" parameter input only [inbox, notmuch::review, unread]
  • Jani Nikula—[PATCH 3/6] cli: abstract subcommand finding into a new function [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH 3/6] cli: abstract subcommand finding into a new function [inbox, notmuch::review, unread]
  • Jani Nikula—[PATCH 4/6] cli: plug main notmuch command into subcommand machinery [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH 4/6] cli: plug main notmuch command into subcommand machinery [inbox, notmuch::review, unread]
  • Jani Nikula—[PATCH 5/6] cli: move config open/close to main() from subcommands [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jani Nikula—[PATCH 6/6] cli: add top level --config=FILE option [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH 6/6] cli: add top level --config=FILE option [inbox, notmuch::review, unread]
  • Jameson Graef Rollins—Re: [PATCH 0/6] notmuch cli config changes [inbox, signed, unread]
    • Jani Nikula—Re: [PATCH 0/6] notmuch cli config changes [inbox, unread]
    • David Bremner—Re: [PATCH 0/6] notmuch cli config changes [inbox, unread]
      • Jameson Graef Rollins—Re: [PATCH 0/6] notmuch cli config changes [inbox, signed, unread]
        • David Bremner—Re: [PATCH 0/6] notmuch cli config changes [inbox, unread]
          • Jameson Graef Rollins—Re: [PATCH 0/6] notmuch cli config changes [inbox, signed, unread]
            • David Bremner—Re: [PATCH 0/6] notmuch cli config changes [inbox, unread]
              • Mark Walters—Re: [PATCH 0/6] notmuch cli config changes [inbox, unread]
            • Jani Nikula—Re: [PATCH 0/6] notmuch cli config changes [inbox, unread]
              • David Bremner—Re: [PATCH 0/6] notmuch cli config changes [inbox, unread]