Re: [Patch v2 4/4] cli: add standard option processing to config and setup

Subject: Re: [Patch v2 4/4] cli: add standard option processing to config and setup

Date: Tue, 07 Apr 2015 19:20:38 +0900

To: Mark Walters, notmuch@notmuchmail.org

Cc:

From: David Bremner

Mark Walters <markwalters1009@gmail.com> writes:

>
> Why "setup" here rather than argv[0] or similar? It seems inconsistent
> with the other cases.
>
> Best wishes
>
> Mark

You're right this deserves a comment. notmuch_setup_command is actually
called with argv=NULL (hence the unused (char * argv). The argument
types are constrained by the fact we use a table of function pointers to
dispatch.

d

• Previous message (by thread): Re: argument parsing refactoring round3

Thread:

• David Bremner—argument parsing refactor, add shared options [inbox, unread]
  • David Bremner—[PATCH 1/4] cli: ignore config argument of notmuch_help_command [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 2/4] cli: refactor notmuch_help_command [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 3/4] cli: define shared options, use for --help and --version [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 4/4] cli: add standard option processing to config and setup [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH 4/4] cli: add standard option processing to config and setup [inbox, unread]
      • David Bremner—argument parsing refactoring, round 2 [inbox, unread]
        • David Bremner—[Patch v2 1/4] cli: ignore config argument of notmuch_help_command [inbox, notmuch::obsolete, notmuch::patch, unread]
        • David Bremner—[Patch v2 2/4] cli: refactor notmuch_help_command [inbox, notmuch::obsolete, notmuch::patch, unread]
        • David Bremner—[Patch v2 3/4] cli: define shared options, use for --help and --version [inbox, notmuch::obsolete, notmuch::patch, unread]
          • Mark Walters—Re: [Patch v2 3/4] cli: define shared options, use for --help and --version [inbox, unread]
        • David Bremner—[Patch v2 4/4] cli: add standard option processing to config and setup [inbox, notmuch::obsolete, notmuch::patch, unread]
          • Mark Walters—Re: [Patch v2 4/4] cli: add standard option processing to config and setup [inbox, unread]
            • David Bremner—Re: [Patch v2 4/4] cli: add standard option processing to config and setup [inbox, unread]
        • Mark Walters—Re: argument parsing refactoring, round 2 [inbox, unread]
          • David Bremner—argument parsing refactoring round3 [inbox, unread]
            • David Bremner—[PATCH 1/4] cli: ignore config argument of notmuch_help_command [inbox, notmuch::patch, notmuch::pushed, unread]
            • David Bremner—[PATCH 2/4] cli: refactor notmuch_help_command [inbox, notmuch::patch, notmuch::pushed, unread]
            • David Bremner—[PATCH 3/4] cli: define shared options, use for --help and --version [inbox, notmuch::patch, notmuch::pushed, unread]
            • David Bremner—[PATCH 4/4] cli: add standard option processing to config, help and setup [inbox, notmuch::patch, notmuch::pushed, unread]
              • David Bremner—[PATCH] fixup! cli: add standard option processing to config, help and setup [inbox, notmuch::patch, notmuch::pushed, unread]
            • guyzmo—Re: argument parsing refactoring round3 [inbox, unread]
              • David Bremner—Re: argument parsing refactoring round3 [inbox, unread]
                • David Bremner—Re: argument parsing refactoring round3 [inbox, unread]
                  • Tomi Ollila—Re: argument parsing refactoring round3 [inbox, unread]
            • David Bremner—Re: argument parsing refactoring round3 [inbox, unread]