Re: [PATCH] test: swap order of arguments of test_expect_equal

Subject:Re: [PATCH] test: swap order of arguments of test_expect_equal

Date:Thu, 06 Apr 2017 14:40:12 -0300

To:Tomi Ollila ,notmuch@notmuchmail.org

Cc:

From:David Bremner


Tomi Ollila <tomi.ollila@iki.fi> writes:

> On Thu, Apr 06 2017, David Bremner <david@tethera.net> wrote:
>
>> For some reason (probably inherited from git), the order arguments for
>> test_expect_equal was "$output $expected"; this again matters when
>> generating diffs.
>> ---
>
> IMO these both of these should use expected - output argument order.
>
> But more important than that is to get 
> id:20170405003630.15104-1-david@tethera.net merged soon so confusion
> of output ends and if someone(tm) is doing near-future test changes
> risk of collisions can be avoided.

OK, pushed the first two to master.

d

Thread: