Re: [PATCH 4/8] cli: run uncrustify

Subject: Re: [PATCH 4/8] cli: run uncrustify

Date: Fri, 14 Jun 2019 07:30:50 -0300

To: Tomi Ollila, notmuch@notmuchmail.org

Cc:

From: David Bremner


Tomi Ollila <tomi.ollila@iki.fi> writes:

>> - * 	These default configuration settings are determined as
>> - * 	follows:
>> + *      These default configuration settings are determined as
>> + *      follows:
>
> The change above looks strange, why change tabs to spaces, if not elsewhere

I guess it's because pre-uncrustify there is a space before the
tab. Possibly a bug in uncrustify, but easy to work around by running
M-x whitespace-cleanup on that region first.

>
>>   *
>>   *		database_path:		$MAILDIR, otherwise $HOME/mail
>>   *
>>   *		user_name:		$NAME variable if set, otherwise
>>   *					read from /etc/passwd
>>   *
>> - *		user_primary_mail: 	$EMAIL variable if set, otherwise
>> + *		user_primary_mail:      $EMAIL variable if set, otherwise
>
> The above I',m not sure; '> +' disturbs experience too much ;/
>
> ... have to create worktree and apply series to see better...
>
same here.


>>   *					constructed from the username and
>>   *					hostname of the current machine.
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Thread: