Re: [PATCH 4/7] util/crypto: _n_m_crypto_potential_payload returns whether part is the payload

Subject: Re: [PATCH 4/7] util/crypto: _n_m_crypto_potential_payload returns whether part is the payload

Date: Wed, 31 Jul 2019 23:29:21 -0400

To: David Bremner, Notmuch Mail

Cc:

From: Daniel Kahn Gillmor

On Wed 2019-07-31 23:15:55 -0400, Daniel Kahn Gillmor wrote:
> On Wed 2019-07-31 08:57:56 -0300, David Bremner wrote:
>> what about leaving an assert or call to INTERNAL_ERROR here? I'm a bit
>> concerned this change is making the code less robust. I guess we'll see
>> a segfault, if either is NULL, but that seems bit icky to rely on.
>
> Sure, INTERNAL_ERROR makes sense, i think.

hm, INTERNAL_ERROR is only a valid symbol within libnotmuch, and
util/crypto.o is *not* within libnotmuch.  So i think i'll use assert,
by analogy with hex_encode() in util/hex_encode.c.  let me know if you
think that's a bad idea for some reason.

   --dkg

_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

• Previous message (by thread): Re: [PATCH 5/7] util/repair: add _notmuch_repair_crypto_payload_skip_legacy_display

Thread:

• Daniel Kahn Gillmor—v3 of legacy-display cleanup [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH 1/7] mime-node: split out _mime_node_set_up_part [inbox, notmuch::obsolete, notmuch::patch, unread]
    • William Casarin—Re: [PATCH 1/7] mime-node: split out _mime_node_set_up_part [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH 1/7] mime-node: split out _mime_node_set_up_part [inbox, signed, unread]
  • Daniel Kahn Gillmor—[PATCH 2/7] repair: set up codebase for repair functionality [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 3/7] test: avoid showing legacy-display parts [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 4/7] util/crypto: _n_m_crypto_potential_payload returns whether part is the payload [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH 4/7] util/crypto: _n_m_crypto_potential_payload returns whether part is the payload [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH 4/7] util/crypto: _n_m_crypto_potential_payload returns whether part is the payload [inbox, signed, unread]
        • Daniel Kahn Gillmor—Re: [PATCH 4/7] util/crypto: _n_m_crypto_potential_payload returns whether part is the payload [inbox, signed, unread]
          • David Bremner—Re: [PATCH 4/7] util/crypto: _n_m_crypto_potential_payload returns whether part is the payload [inbox, unread]
            • Daniel Kahn Gillmor—Re: [PATCH 4/7] util/crypto: _n_m_crypto_potential_payload returns whether part is the payload [inbox, signed, unread]
        • David Bremner—Re: [PATCH 4/7] util/crypto: _n_m_crypto_potential_payload returns whether part is the payload [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH 5/7] util/repair: add _notmuch_repair_crypto_payload_skip_legacy_display [inbox, notmuch::obsolete, notmuch::patch, unread]
    • William Casarin—Re: [PATCH 5/7] util/repair: add _notmuch_repair_crypto_payload_skip_legacy_display [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH 5/7] util/repair: add _notmuch_repair_crypto_payload_skip_legacy_display [inbox, signed, unread]
    • David Bremner—Re: [PATCH 5/7] util/repair: add _notmuch_repair_crypto_payload_skip_legacy_display [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH 5/7] util/repair: add _notmuch_repair_crypto_payload_skip_legacy_display [inbox, signed, unread]
  • Daniel Kahn Gillmor—[PATCH 6/7] cli/{show,reply}: skip over legacy-display parts [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 7/7] index: avoid indexing legacy-display parts [inbox, notmuch::obsolete, notmuch::patch, unread]
  • William Casarin—Re: v3 of legacy-display cleanup [inbox, unread]