Re: [Patch v6 4/8] lib: add "verbose" versions of notmuch_database_{open,create}

Subject: Re: [Patch v6 4/8] lib: add "verbose" versions of notmuch_database_{open,create}

Date: Sun, 29 Mar 2015 00:46:20 +0100

To: Tomi Ollila, notmuch@notmuchmail.org

Cc:

From: David Bremner

Tomi Ollila <tomi.ollila@iki.fi> writes:

>
> Just that this small piece of code above git pass my sparse sieve, perhaps
> this could be amended to:
>
>     if (message) {
>         if (status_string)
>             *status_string = message;
>         else 
>             free(message);
>     }
>

I amended and pushed. Thanks for all the reviewing.

d

• Previous message (by thread): Re: [Patch v6 4/8] lib: add "verbose" versions of notmuch_database_{open,create}

Thread:

• David Bremner—Library logging overhaul, round 6 [inbox, unread]
  • David Bremner—[Patch v6 1/8] test: Add two tests for error output from notmuch_database_open [inbox, notmuch::patch, notmuch::pushed, unread]
  • David Bremner—[Patch v6 2/8] test: add support for compiling and running C snippets [inbox, notmuch::patch, notmuch::pushed, unread]
  • David Bremner—[Patch v6 3/8] test: add error reporting tests [inbox, notmuch::patch, notmuch::pushed, unread]
  • David Bremner—[Patch v6 4/8] lib: add "verbose" versions of notmuch_database_{open,create} [inbox, notmuch::patch, notmuch::pushed, unread]
    • Tomi Ollila—Re: [Patch v6 4/8] lib: add "verbose" versions of notmuch_database_{open, create} [inbox, unread]
      • David Bremner—Re: [Patch v6 4/8] lib: add "verbose" versions of notmuch_database_{open,create} [inbox, unread]
  • David Bremner—[Patch v6 5/8] lib: add a log function with output to a string in notmuch_database_t [inbox, notmuch::patch, notmuch::pushed, unread]
  • David Bremner—[Patch v6 6/8] lib: add private function to extract the database for a message. [inbox, notmuch::patch, notmuch::pushed, unread]
  • David Bremner—[Patch v6 7/8] lib: replace almost all fprintfs in library with _n_d_log [inbox, notmuch::patch, notmuch::pushed, unread]
  • David Bremner—[Patch v6 8/8] lib: eliminate fprintf from _notmuch_message_file_open [inbox, notmuch::patch, notmuch::pushed, unread]