On Sat, 22 Oct 2016, Tomi Ollila <tomi.ollila@iki.fi> wrote: > On Sat, Oct 22 2016, Mark Walters <markwalters1009@gmail.com> wrote: > >> The command notmuch-interesting-buffer has got out of date -- it >> doesn't mention notmuch-tree, and it still refers to message-mode not >> notmuch-message-mode. Update both of these. >> >> This fixes the bug that notmuch-cycle-notmuch-buffers does not include >> notmuch-tree or notmuch-message-mode buffers in its cycling. > > Looks pretty obvious to me. +1 And works for me. Thanks for fixing this. BR, Jani. > >> >> --- >> >> Jani pointed notmuch-cycle-notmuch-buffers out to me on irc (I hadn't >> known it existed). It seems like it could be very useful. >> >> However, it call notmuch-interesting-buffer which has not been updated >> since 2011, so doesn't know about notmuch-tree or >> notmuch-message-mode. notmuch-tree came into mainline in 2013, and we >> switched to notmuch-message-mode (from message-mode) in August last >> year, so both bugs have been present for quite some time. >> >> Best wishes >> >> Mark >> >> >> >> >> >> >> emacs/notmuch.el | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/emacs/notmuch.el b/emacs/notmuch.el >> index bd08aa0..2fc72b7 100644 >> --- a/emacs/notmuch.el >> +++ b/emacs/notmuch.el >> @@ -1066,8 +1066,9 @@ current search results AND that are tagged with the given tag." >> (with-current-buffer b >> (memq major-mode '(notmuch-show-mode >> notmuch-search-mode >> + notmuch-tree-mode >> notmuch-hello-mode >> - message-mode)))) >> + notmuch-message-mode)))) >> >> ;;;###autoload >> (defun notmuch-cycle-notmuch-buffers () >> -- >> 2.1.4 >> >> _______________________________________________ >> notmuch mailing list >> notmuch@notmuchmail.org >> https://notmuchmail.org/mailman/listinfo/notmuch > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > https://notmuchmail.org/mailman/listinfo/notmuch