Re: [PATCH v2] bindings/python-cffi: search for config by default

Subject: Re: [PATCH v2] bindings/python-cffi: search for config by default

Date: Sun, 09 Jan 2022 16:00:59 -0400

To: notmuch@notmuchmail.org

Cc:

From: David Bremner


David Bremner <david@tethera.net> writes:

> The previous (pre-0.34.2) constructor searched for a config file but
> only if the database path was not specified, and only to retrieve
> database.path. Neither of the available options (CONFIG.SEARCH or
> CONFIG.NONE) matches this semantics exactly, but CONFIG.SEARCH causes
> less breakage for people who relied on the old behaviour to set their
> database.path [1]. Since it also seems like the friendlier option in
> the long run, this commit switches to CONFIG.SEARCH as default.

applied the fixed version to master and release. For some reason I only
tested the original version by running pytest, but the notmuch test
suite actually sets up an environment where the code is run without a
config file, and that failed in the initial version.

d
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: