Re: [PATCH v3 2/2] notmuch-show.el: handle the case where icalendar-import-buffer returns nil

Subject: Re: [PATCH v3 2/2] notmuch-show.el: handle the case where icalendar-import-buffer returns nil

Date: Wed, 21 Nov 2012 23:51:28 -0400

To: Tomi Ollila, notmuch@notmuchmail.org

Cc: tomi.ollila@iki.fi

From: David Bremner


Tomi Ollila <tomi.ollila@iki.fi> writes:

> icalendar-import-buffer can fail by an error signal (which have been
> witnessed) but according to its docstring it can also return nil
> when failing (it returns t when succeeding).
>
> Now that the error is caught by the caller of notmuch-show-inset-part-*
> functions in case icalendar-import-buffer returns nil an explicit
> error is signaled and unwind-protect takes care of deleting the
> temporary file (just in case, it is usually not written to the fs yet).

This one looks OK to me too, although the API that makes it necessary
out to be taken out back...

d

Thread: