Re: [PATCH v4 08/13] test: add database upgrade test from format version 1 to 2

Subject: Re: [PATCH v4 08/13] test: add database upgrade test from format version 1 to 2

Date: Mon, 10 Mar 2014 20:14:05 -0300

To: Jani Nikula, notmuch@notmuchmail.org

Cc:

From: David Bremner


Jani Nikula <jani@nikula.org> writes:

> Test the upgrade from probabilistic to boolean folder: terms, and
> addition of path: terms.
>
> The test depends on the pre-built test corpus and database tarball and
> checksum file being in place. If it's not, the test is skipped. The
> mechanism to fetch the test database will be added later.
>
> At the time of writing, a working test database and checksum file is
> available at
>
>    http://notmuchmail.org/releases/test-databases/
>

Hi Jani;

This test has gotten out of sync with the corpus in the tree. It still
passes because the database tarball on notmuchmail.org is in the
previous (multi-corpus) style. In particular

% cd test
% ../devel/gen-testdb.sh -s v1 -v 0.17
% sed -i s/folders-v1/database-v1/ T530-upgrade.sh 
% ./T530-upgrade

yields several failures.

I think it would be better to update the test to match corpus currently
in the tree.

d

Thread: