Re: [PATCH] cli: notmuch address option defaults update

Subject: Re: [PATCH] cli: notmuch address option defaults update

Date: Fri, 07 Nov 2014 09:53:09 +0100

To: Mark Walters, Tomi Ollila, notmuch@notmuchmail.org

Cc: tomi.ollila@iki.fi

From: David Bremner


Mark Walters <markwalters1009@gmail.com> writes:

>> -	This option has no effect when used with --output=count.
>> +        This option affects the seemingly random output order when
>> +        used with --output=count.
>
> I know what this means but it confused me at first.  How about "When
> used with --output=count this option changes the output from one
> seemingly random order to a different seemingly random order"? 

What about just saying "This option is not supported with
--output=count".
Then the fact that it doesn't crash or error out is a kind of bonus ;).
Of course we could (later?) add a check for --sort && --output=count and
report an errror.

d

Thread: