Re: cleartext indexing version 5

Subject: Re: cleartext indexing version 5

Date: Mon, 16 Oct 2017 18:40:02 -0700

To: Daniel Kahn Gillmor, Notmuch Mail

Cc:

From: Jameson Graef Rollins

On Sun, Oct 15 2017, Daniel Kahn Gillmor <dkg@fifthhorseman.net> wrote:
> I welcome review and feedback.

I have reviewed this patch series and everything looks in order.  Coding
style is consistent with notmuch standards.  The patch is
feature-complete, with appropriate documentation.  All tests pass.  I am
now using this series by default, with config set to automatically index
encrypted mail ("index.try_decrypt=true"), and have experienced no
issues.

I am strongly in support of this patch series.  Daniel is doing crucial
work pushing for widespread use of email encryption.  This series is
necessary in the context of that larger goal.  He's been pushing this
series for a year and a half now, so I think it's appropriate that it
final be integrated.

jamie.

_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

• Previous message (by thread): Re: cleartext indexing version 5

Thread:

• Daniel Kahn Gillmor—cleartext indexing version 5 [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v5 01/12] crypto: move into libnotmuch_util [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v5 02/12] crypto: make shared crypto code behave library-like [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v5 03/12] index: implement notmuch_indexopts_t with try_decrypt [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v5 04/12] properties: add notmuch_message_remove_all_properties_with_prefix() [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v5 05/12] reindex: drop all properties named with prefix "index." [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v5 06/12] crypto: index encrypted parts when indexopts try_decrypt is set. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v5 07/12] config: indexing defaults will be stored in the database. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v5 08/12] config: define new option index.try_decrypt [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v5 09/12] cli: set up shared command-line arguments for indexing [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v5 10/12] cli/new: add --try-decrypt=(true|false) [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v5 11/12] cli/insert: add --try-decrypt=(true|false) [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH v5 12/12] cli/reindex: add --try-decrypt=(true|false) [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jameson Graef Rollins—Re: cleartext indexing version 5 [inbox, signed, unread]