Re: [PATCH v1 1/2] test: Absolute and relative directory paths.

Subject: Re: [PATCH v1 1/2] test: Absolute and relative directory paths.

Date: Fri, 07 Sep 2018 21:05:38 -0300

To: David Edmondson, notmuch@notmuchmail.org

Cc:

From: David Bremner


David Edmondson <dme@dme.org> writes:

> ---
>  test/T030-config.sh | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/test/T030-config.sh b/test/T030-config.sh
> index e91c3659..f36695c6 100755
> --- a/test/T030-config.sh
> +++ b/test/T030-config.sh
> @@ -99,4 +99,14 @@ test_expect_equal "$(notmuch --config=alt-config-link config get user.name)" \
>  test_begin_subtest "Writing config file through symlink follows symlink"
>  test_expect_equal "$(readlink alt-config-link)" "alt-config"
>  
> +test_begin_subtest "Absolute database path returned"
> +notmuch config set database.path ${HOME}/Maildir
> +test_expect_equal "$(notmuch config get database.path)" \
> +		  "${HOME}/Maildir"
> +
> +test_begin_subtest "Relative database path properly expanded"
> +notmuch config set database.path Maildir
> +test_expect_equal "$(notmuch config get database.path)" \
> +		  "${HOME}/Maildir"
> +
>  test_done
> -- 

We want the test suite to pass after every commit, so you need to either
squash the second test into the next commit, or mark it with
test_subtest_known_broken. I'm fine with either option.

d
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Thread: