Re: Handle PKCS#7 signedData (S/MIME single-part clearsigned)

Subject: Re: Handle PKCS#7 signedData (S/MIME single-part clearsigned)

Date: Mon, 09 Dec 2019 10:59:24 -0800

To: William Casarin, Daniel Kahn Gillmor, Notmuch Mail

Cc:

From: Jameson Graef Rollins

On Mon, Dec 09 2019, William Casarin <jb55@jb55.com> wrote:
> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
>> Several of the patches should be simple to read and uncontroversial (I
>> hope!), and I welcome/encourage merging of those patches to reduce the
>> length of the remaining series.
>
> I did a quick skim and it looks ok, although I'm not super familiar with
> S/MIME. Any steps toward S/MIME support gets a Concept ACK from me!

+1 on this.  Anything that pushes better crypto support is always good.
I gave the series a casual once over and it looks good to me, but I
haven't done an in-depth code review.

jamie.
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

• Previous message (by thread): Re: Handle PKCS#7 signedData (S/MIME single-part clearsigned)

Thread:

• Daniel Kahn Gillmor—Handle PKCS#7 signedData (S/MIME single-part clearsigned) [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH 01/14] mime-node: Pass the correct flags to g_mime_multipart_signed_verify [inbox, notmuch::needs-review, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 02/14] tests/smime: Always use --batch with gpgsm [inbox, notmuch::needs-review, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 03/14] tests/smime: Include the Sample LAMPS Certificate Authority [inbox, notmuch::needs-review, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 04/14] tests/smime: consistently quote $GNUPGHOME [inbox, notmuch::needs-review, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 05/14] test-lib.sh: add test_valid_json [inbox, notmuch::needs-review, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 06/14] tests/smime: add tests for S/MIME SignedData [inbox, notmuch::needs-review, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 07/14] lib: index PKCS7 SignedData parts [inbox, notmuch::needs-review, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 08/14] mime-node: rename decrypted_child to unwrapped_child [inbox, notmuch::needs-review, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 09/14] mime-node: Clean up unwrapped MIME parts correctly. [inbox, notmuch::needs-review, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 10/14] cli: include wrapped part of PKCS#7 SignedData in the MIME tree [inbox, notmuch::needs-review, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 11/14] cli/show: If a leaf part has children, show them instead of omitting [inbox, notmuch::needs-review, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 12/14] cli/reply: Ignore PKCS#7 wrapper parts when replying [inbox, notmuch::needs-review, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 13/14] cli: sprinter should be able to print an unsigned long [inbox, notmuch::needs-review, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 14/14] cli: Avoid bogus signature dates from GMime [inbox, notmuch::needs-review, notmuch::obsolete, notmuch::patch, unread]
  • William Casarin—Re: Handle PKCS#7 signedData (S/MIME single-part clearsigned) [inbox, unread]
    • Jameson Graef Rollins—Re: Handle PKCS#7 signedData (S/MIME single-part clearsigned) [inbox, unread]