Re: [notmuch] [PATCH 2/2] add some very rudimentary support for handling html parts

Subject: Re: [notmuch] [PATCH 2/2] add some very rudimentary support for handling html parts

Date: Fri, 27 Nov 2009 20:49:40 -0800

To: Alexander Botero-Lowry, notmuch@notmuchmail.org

Cc:

From: Carl Worth


On Wed, 25 Nov 2009 01:13:33 -0800, Alexander Botero-Lowry <alex.boterolowry@gmail.com> wrote:
> I was planning to be committing super awesome mime-handling support
> that would make notmuch rival every mail program ever for pure mime
> awesomeness. It turns out, that mime is confusing and hard, and the
> mm-* functions do awesome things like provide different forms based
> on the number and composition of mime-parts in a document, so I set
> my first-pass goal a bit lower. What this does, is if there is an
> html mime-part in the message and it's the first part, it gets inlined
> using `mm-display-part'. This should solve the biggest problem I was
> facing, which is HTML only messages that I have to go into the awful
> mime-mode to view.
> 
> This still even leaves in the Non-text part: message and all.

A very nice first step for support for HTML mail. Thanks, Alex!

This is definitely easier than viewing the raw mail message and trying
to read past all the tags. I did exercise some editorial license and
change the commit message, (removing references to future ideas,
etc.). Here's what I ended up with before pushing:

    Add some very rudimentary support for handling html parts
    
    If there is an html mime-part in the message and it's the first part,
    it gets inlined using `mm-display-part' to convert it to plain text.
    
    The HTML content is still available as a non-text part as well.

Thanks again,

-Carl
part-000.sig (application/pgp-signature)

Thread: