Re: [notmuch] [PATCH] json_quote_str should handle non-ASCII characters

Subject: Re: [notmuch] [PATCH] json_quote_str should handle non-ASCII characters

Date: Tue, 13 Apr 2010 08:36:06 -0700

To: Gregor Hoffleit, notmuch

Cc:

From: Carl Worth

On Thu, 04 Mar 2010 11:40:03 +0100, Gregor Hoffleit <gregor@hoffleit.de> wrote:
> The current code in json_quote_str() only accepts strict printable ASCII
> code points (i.e. 32-127), all other code points are dropped from the
> JSON output.
> 
> This patch accepts code points 32-255.

Thanks, Gregor!

I've pushed this patch out now.

And I noted in our TODO file that we really should add some tests to the
test suite to exercise our --format=json code paths. It would be nice to
ensure we don't have any regressions in this area later.

-Carl
part-000.sig (application/pgp-signature)

Thread: