Re: [PATCH 1/4] notmuch-opts.[ch]: new argument parsing framework for notmuch.

Subject: Re: [PATCH 1/4] notmuch-opts.[ch]: new argument parsing framework for notmuch.

Date: Tue, 06 Dec 2011 22:55:39 +0200

To: David Bremner, notmuch@notmuchmail.org

Cc: David Bremner

From: Jani Nikula

On Sun,  4 Dec 2011 11:47:52 -0400, David Bremner <david@tethera.net> wrote:
> +	    case NOTMUCH_OPT_INT:
> +		if (try->output_var)
> +		    *((int *)try->output_var) =
> +			atol (arg + strlen (try->name) +  1);

Looking at patch 4 and the existing handling of int params, I'd really
like this one to check that the string is non-empty and that all of the
string is parsed (and doesn't contain garbage at the end).

BR,
Jani.

• Previous message (by thread): Re: [PATCH v4 1/5] command-line-arguments.[ch]: new argument parsing framework for notmuch.

Thread:

• David Bremner— [inbox, unread]
  • David Bremner—[PATCH 1/4] notmuch-opts.[ch]: new argument parsing framework for notmuch. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Jani Nikula—Re: [PATCH 1/4] notmuch-opts.[ch]: new argument parsing framework for notmuch. [inbox, notmuch::review, unread]
      • David Bremner—Re: [PATCH 1/4] notmuch-opts.[ch]: new argument parsing framework for notmuch. [inbox, unread]
        • David Bremner—[PATCH 1/4] command-line-arguments.[ch]: new argument parsing framework for notmuch. [inbox, notmuch::obsolete, notmuch::patch, unread]
          • David Bremner—[PATCH 2/4] notmuch-dump: convert to command-line-arguments [inbox, notmuch::obsolete, notmuch::patch, unread]
          • David Bremner—[PATCH 3/4] notmuch-restore: convert to command-line-arguments [inbox, notmuch::obsolete, notmuch::patch, unread]
          • David Bremner—[PATCH 4/4] notmuch-search: convert to command-line-arguments [inbox, notmuch::obsolete, notmuch::patch, unread]
        • David Bremner— [inbox, unread]
          • David Bremner—[PATCH v4 1/5] command-line-arguments.[ch]: new argument parsing framework for notmuch. [inbox, notmuch::patch, notmuch::pushed, unread]
            • David Bremner—Re: [PATCH v4 1/5] command-line-arguments.[ch]: new argument parsing framework for notmuch. [inbox, unread]
          • David Bremner—[PATCH v4 2/5] test: tests for command-line-arguments.c [inbox, notmuch::patch, notmuch::pushed, unread]
          • David Bremner—[PATCH v4 3/5] notmuch-dump: convert to command-line-arguments [inbox, notmuch::patch, notmuch::pushed, unread]
          • David Bremner—[PATCH v4 4/5] notmuch-restore: convert to command-line-arguments [inbox, notmuch::patch, notmuch::pushed, unread]
          • David Bremner—[PATCH v4 5/5] notmuch-search: convert to command-line-arguments [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jani Nikula—Re: [PATCH 1/4] notmuch-opts.[ch]: new argument parsing framework for notmuch. [inbox, unread]
  • David Bremner—[PATCH 2/4] notmuch-dump: convert to notmuch-opts argument handling. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Jani Nikula—Re: [PATCH 2/4] notmuch-dump: convert to notmuch-opts argument handling. [inbox, unread]
  • David Bremner—[PATCH 3/4] notmuch-restore: convert to notmuch-opts argument handling. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Jani Nikula—Re: [PATCH 3/4] notmuch-restore: convert to notmuch-opts argument handling. [inbox, unread]
  • David Bremner—[PATCH 4/4] notmuch-search: convert to notmuch-opts argument parsing. [inbox, notmuch::obsolete, notmuch::patch, unread]