Re: [PATCH 2/2] emacs: new mua mailto: URI handler

Subject: Re: [PATCH 2/2] emacs: new mua mailto: URI handler

Date: Sun, 15 Apr 2012 00:22:15 +0300

To: Jameson Graef Rollins, Notmuch Mail


From: Jani Nikula

Jameson Graef Rollins <> writes:

> On Sat, Apr 14 2012, Jani Nikula <> wrote:
>> I'm going through the review queue right now, tagging notmuch::stale any
>> patches that don't apply on master. I was just about to nmbug push stale
>> on this one (2/2). Is that in error? Care to verify?
> Yes, it is an error.  This patch applies to master.  Did you in fact
> verify that it doesn't?  You should not be tagging patches stale if they
> in fact still apply to master.  If they still need review or something
> else that's a different matter.  Please don't mark things as stale if
> they are not.

My nmfirehose script flagged the patch as not applying, and I verified
this (and all of them) by hand, using the emacs interface to save the
patch. No, I'm not intentionally tagging patches stale if they apply,
but I'll stop for now in case there's a bug somewhere (incl. PEBKAC)
breaking the patches and thus making them not apply.

> Obviously I still care about this patch, or I wouldn't have re-commented
> on it.

I was doing this purely based on whether the patches apply or not.