Re: [PATCH 07/23] test/crypto: mark extra space in userid as a bug in gmime-2.6

Subject: Re: [PATCH 07/23] test/crypto: mark extra space in userid as a bug in gmime-2.6

Date: Thu, 06 Jul 2017 10:15:47 -0400

To: Tomi Ollila, David Bremner, notmuch@notmuchmail.org, notmuch@freelists.org

Cc:

From: Daniel Kahn Gillmor

On Wed 2017-07-05 23:26:18 +0300, Tomi Ollila wrote:
> On Sat, Jun 03 2017, David Bremner wrote:
>
>> I can't see the space in the output of gpg -K --with-colons
 [...]
> You could add a variable which is set to ' ' when gmime_2 is used and ''
> when gmime_3 is used and insert that just like '"$FINGERPRINT"' is added
> -- that change would not need to live there forever -- just couple of
> years until we drop support for gmime_2... ( ;) )
>
> e.e. "userid: "'"$GM2SPC"'Notmuch Test Suite..."
>
> (if nimed as such, T350-crypto.sh -local variable)

I think this would be a mistake.  This is clearly a bug in gmime 2.6,
and we should be marking it as such.  the User ID does not have a
leading space (see test/gnupg-secret-key.NOTE for how it was generated).

        --dkg

• Previous message (by thread): Re: [PATCH v2 1/4] cli/crypto: treat failure to create a crypto context as fatal.

Thread:

• David Bremner— [inbox, unread]
  • David Bremner—[PATCH 01/23] emacs: convert to use format-version 3 [inbox, notmuch::patch, notmuch::pushed, unread]
  • David Bremner—[PATCH 02/23] devel/schemata: describe version 4 [inbox, notmuch::patch, notmuch::pushed, unread]
  • David Bremner—[PATCH 03/23] cli: implement structured output version 4 [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH 03/23] cli: implement structured output version 4 [inbox, unread]
  • David Bremner—[PATCH 04/23] test/multipart: reorganize creation of multipart message [inbox, notmuch::patch, notmuch::pushed, unread]
  • David Bremner—[PATCH 05/23] test: mark inclusion of headers as broken in gmime-2.x [inbox, notmuch::patch, notmuch::pushed, unread]
  • David Bremner—[PATCH 06/23] test: mark test as broken in gmime 3.0 [inbox, notmuch::patch, notmuch::pushed, unread]
  • David Bremner—[PATCH 07/23] test/crypto: mark extra space in userid as a bug in gmime-2.6 [inbox, notmuch::patch, notmuch::pushed, unread]
    • Tomi Ollila—Re: [PATCH 07/23] test/crypto: mark extra space in userid as a bug in gmime-2.6 [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH 07/23] test/crypto: mark extra space in userid as a bug in gmime-2.6 [inbox, signed, unread]
  • David Bremner—[PATCH 08/23] test: add test for modified pgp/mime signed message [inbox, notmuch::patch, notmuch::pushed, unread]
  • David Bremner—[PATCH 09/23] test/crypto: add test for corrupted signatures [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH 09/23] test/crypto: add test for corrupted signatures [inbox, signed, unread]
  • David Bremner—[PATCH 10/23] test: test parsing of malformed from addresses [inbox, notmuch::patch, notmuch::wontfix, unread]
  • David Bremner—[PATCH 11/23] cli: replace use of g_mime_message_get_date_as_string [inbox, notmuch::patch, notmuch::pushed, unread]
  • David Bremner—[PATCH 12/23] cli: replace use of g_mime_message_get_reply_to [inbox, notmuch::patch, notmuch::pushed, unread]
  • David Bremner—[PATCH 13/23] lib/cli: replace use of g_mime_message_get_sender [inbox, notmuch::patch, notmuch::pushed, unread]
  • David Bremner—[PATCH 14/23] cli: replace use of g_mime_message_get_recipients [inbox, notmuch::patch, notmuch::pushed, unread]
  • David Bremner—[PATCH 15/23] util: fake gmime-2.6 compatible API for gmime-3.0 [inbox, notmuch::patch, notmuch::pushed, unread]
  • David Bremner—[PATCH 16/23] cli: generalize use of GMIME_SIGNATURE_{ERROR, STATUS} to gmime-3 [inbox, notmuch::patch, notmuch::pushed, unread]
    • Daniel Kahn Gillmor—Re: [PATCH 16/23] cli: generalize use of GMIME_SIGNATURE_{ERROR, STATUS} to gmime-3 [inbox, unread]
  • David Bremner—[PATCH 17/23] cli: hide rename of GMimeCertificateTrust [inbox, notmuch::patch, notmuch::pushed, unread]
  • David Bremner—[PATCH 18/23] lib: wrap use of g_mime_utils_header_decode_date [inbox, notmuch::patch, notmuch::pushed, unread]
  • David Bremner—[PATCH 19/23] lib: refactor _notmuch_messsage_file_get_combined_header [inbox, notmuch::patch, notmuch::pushed, unread]
  • David Bremner—[PATCH 20/23] lib: add version of _n_m_f_get_combinded_header for gmime 3.0 [inbox, notmuch::patch, notmuch::pushed, unread]
  • David Bremner—[PATCH 21/23] lib: paper over allocation difference [inbox, notmuch::patch, notmuch::pushed, unread]
  • David Bremner—[PATCH 22/23] cli: make keyid from fingerprint in gmime 3.0 [inbox, notmuch::patch, notmuch::pushed, unread]
  • David Bremner—[PATCH 23/23] cli: wrap getting uid [inbox, notmuch::patch, notmuch::pushed, unread]
    • Daniel Kahn Gillmor—[PATCH 1/3] config: deprecate/drop crypto.gpg_path under gmime 2.6/3.0 [inbox, notmuch::patch, notmuch::pushed, unread]
      • Daniel Kahn Gillmor—[PATCH 2/3] clean up use of constants in g_mime_multipart_ wrappers [inbox, notmuch::patch, notmuch::pushed, unread]
      • Daniel Kahn Gillmor—[PATCH 3/3] crypto: Avoid explicit handling of GMimeCryptoContext in gmime 3.0 [inbox, notmuch::obsolete, notmuch::patch, unread]
        • David Bremner—Re: [PATCH 3/3] crypto: Avoid explicit handling of GMimeCryptoContext in gmime 3.0 [inbox, unread]
        • David Bremner—[PATCH 1/4] cli/crypto: treat failure to create a crypto context as fatal. [inbox, notmuch::obsolete, notmuch::patch, unread]
          • David Bremner—[PATCH 2/4] cli/crypto: eliminated compiler warnings about unused arguments [inbox, notmuch::obsolete, notmuch::patch, unread]
          • David Bremner—[PATCH 3/4] crypto: Avoid explicit handling of GMimeCryptoContext in gmime 3 [inbox, notmuch::obsolete, notmuch::patch, unread]
            • Daniel Kahn Gillmor—Re: [PATCH 3/4] crypto: Avoid explicit handling of GMimeCryptoContext in gmime 3 [inbox, signed, unread]
              • Daniel Kahn Gillmor—[PATCH v2 1/4] cli/crypto: treat failure to create a crypto context as fatal. [inbox, notmuch::patch, notmuch::pushed, unread]
                • Daniel Kahn Gillmor—[PATCH v2 2/4] cli/crypto: eliminated compiler warnings about unused arguments [inbox, notmuch::patch, notmuch::pushed, unread]
                • Daniel Kahn Gillmor—[PATCH v2 3/4] crypto: Avoid explicit handling of GMimeCryptoContext in gmime 3 [inbox, notmuch::patch, notmuch::pushed, unread]
                • Daniel Kahn Gillmor—[PATCH v2 4/4] crypto: clean up unused definitions in gmime 3.0 [inbox, notmuch::patch, notmuch::pushed, unread]
                • David Bremner—Re: [PATCH v2 1/4] cli/crypto: treat failure to create a crypto context as fatal. [inbox, unread]
          • David Bremner—[PATCH 4/4] crypto: clean up unused definitions in gmime 3.0 [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Daniel Kahn Gillmor—Re: [PATCH 1/3] config: deprecate/drop crypto.gpg_path under gmime 2.6/3.0 [inbox, signed, unread]