Re: [PATCH] crypto: signature verification reports valid User IDs

Subject:Re: [PATCH] crypto: signature verification reports valid User IDs

Date:Fri, 08 Dec 2017 14:36:04 -0400

To:Daniel Kahn Gillmor ,Notmuch Mail

Cc:

From:David Bremner


Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:

> @@ -478,9 +478,10 @@ fi
>  # we need to have a version >= 2.6.5 to avoid a crypto bug. We need
>  # 2.6.7 for permissive "From " header handling.
>  GMIME_MINVER=2.6.7
> +GMIME3_MINVER=3.0.3

Does this change mean notmuch won't build at all for people with gmime-3
< 3.0.3? I understand that's not a problem in Debian, but what about in
general?

>  
> +
> +static const char*
> +_get_certificate_valid_userid (GMimeCertificate *cert)
> +{

Since we already have util/gmime-extra.c to deal with differences
between gmime-3.0 and 2.6, and since this code is purely gmime related
(not using any notmuch data or types), it makes sense to me put this
(split) there. I guess we might use a different prefix for stuff we add,
although iirc we didn't bother for zlib-extra.c

d



_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Thread: