Re: [PATCH] CLI/restore: handle missing keys and values in config data.

Subject: Re: [PATCH] CLI/restore: handle missing keys and values in config data.

Date: Sun, 07 Jan 2018 20:12:14 -0400

To: Daniel Kahn Gillmor, notmuch@notmuchmail.org

Cc:

From: David Bremner


Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:

> On Sun 2018-01-07 17:30:25 -0400, David Bremner wrote:
>> Although such lines can't occur in notmuch dump output, they might be
>> useful for clearing config, and anyway segfaulting is not the best
>> error message.
>
> I don't think we want "notmuch restore" to actually clear any
> configurations (it's always been additive thus far and changing that
> seems dicey to me), but the patch itself here looks good to me.

I'm not sure how to reconcile those two statements: the patch does clear
configuration if given a key without a value. 

_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Thread: