Re: emacs: Split wide window vertically for tree mode message pane

Subject: Re: emacs: Split wide window vertically for tree mode message pane

Date: Thu, 10 May 2018 17:57:18 -0300

To: Tomi Ollila, Prof Jayanth R Varma, notmuch@notmuchmail.org

Cc:

From: David Bremner


Tomi Ollila <tomi.ollila@iki.fi> writes:

> On Wed, May 09 2018, David Bremner wrote:
>
>> Prof Jayanth R Varma <jrvarma@gmail.com> writes:
>>
>>> This patch modifies the function notmuch-tree-show-message-in in 
>>> notmuch-tree.el to split the window vertically while creating a 
>>> message pane in tree-mode if the window is wider than 160 (so that 
>>> after splitting, the message pane can show the standard 76 
>>> character plain text email lines without wrapping).
>>
>> First, I'm sorry to take so long to review this.  A few comments.
>>
>> 1) I'm reluctant to add new features to notmuch without corresponding
>>    tests. Currently all of our emacs tests use a standard terminal width
>>    (I think 80). Perhaps Tomi knows how hard it would be to override for
>>    a single test.

>
> That would be pretty simple; we'd add variable for colums to be set before
> test... buf for this particular case I don't know how there could be any
> sensible test done 

I was thinking basically the tests with output in
emacs-tree.expected-output, with the other split.

d
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Thread: