Re: [PATCH 3/3] emacs: Drop content-free "Unknown signature status" button

Subject: Re: [PATCH 3/3] emacs: Drop content-free "Unknown signature status" button

Date: Thu, 23 May 2019 22:13:59 -0300

To: Daniel Kahn Gillmor, Notmuch Mail

Cc:

From: David Bremner

Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:

> diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el
> index 353f721e..68171153 100644
> --- a/emacs/notmuch-crypto.el
> +++ b/emacs/notmuch-crypto.el
> @@ -93,6 +93,7 @@ mode."
>  (defun notmuch-crypto-insert-sigstatus-button (sigstatus from)
>    (let* ((status (plist-get sigstatus :status))
>  	 (help-msg nil)
> +	 (show-button t)
>  	 (label "Signature not processed")

This should probably be nil, since that particular value is never used,
iiuc. I can amend it if you agree.
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

• Previous message (by thread): Re: [PATCH 3/3] emacs: Drop content-free "Unknown signature status" button

Thread:

• Daniel Kahn Gillmor—[PATCH 1/3] emacs: test notmuch-show during message decryption [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Kahn Gillmor—[PATCH 2/3] test: show what emacs sees of an encrypted message when crypto is disabled [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
    • David Bremner—Re: [PATCH 2/3] test: show what emacs sees of an encrypted message when crypto is disabled [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH 3/3] emacs: Drop content-free "Unknown signature status" button [inbox, notmuch::patch, notmuch::pushed, unread]
    • Daniel Kahn Gillmor—Re: [PATCH 3/3] emacs: Drop content-free "Unknown signature status" button [inbox, signed, unread]
      • Daniel Kahn Gillmor—Re: [PATCH 3/3] emacs: Drop content-free "Unknown signature status" button [inbox, signed, unread]
    • Daniel Kahn Gillmor—Re: [PATCH 3/3] emacs: Drop content-free "Unknown signature status" button [inbox, signed, unread]
    • David Bremner—Re: [PATCH 3/3] emacs: Drop content-free "Unknown signature status" button [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH 3/3] emacs: Drop content-free "Unknown signature status" button [inbox, signed, unread]
        • David Bremner—Re: [PATCH 3/3] emacs: Drop content-free "Unknown signature status" button [inbox, unread]
          • Daniel Kahn Gillmor—Re: [PATCH 3/3] emacs: Drop content-free "Unknown signature status" button [inbox, unread]
    • David Bremner—Re: [PATCH 3/3] emacs: Drop content-free "Unknown signature status" button [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v2 1/3] emacs: test notmuch-show during message decryption [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH v2 1/3] emacs: test notmuch-show during message decryption [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH v2 1/3] emacs: test notmuch-show during message decryption [inbox, signed, unread]
        • Daniel Kahn Gillmor—[PATCH v3 1/3] emacs: test notmuch-show during message decryption [inbox, notmuch::patch, notmuch::pushed, unread]
          • David Bremner—Re: [PATCH v3 1/3] emacs: test notmuch-show during message decryption [inbox, unread]