David Bremner <david@tethera.net> writes: > Damien Cassou <damien@cassou.me> writes: > >> Is anyone interested in reviewing this patch? It prevents which-func >> (which uses imenu) from randomly re-centering the window while >> navigating. >> >> -- >> Damien Cassou >> >> "Success is the ability to go from one failure to another without >> losing enthusiasm." --Winston Churchill >> _______________________________________________ >> notmuch mailing list -- notmuch@notmuchmail.org >> To unsubscribe send an email to notmuch-leave@notmuchmail.org > > Maybe while you are waiting for a more substantive review you can > rework the commit message to > > https://notmuchmail.org/contributing/#index5h2 > > I have never understood the goal of the (GNU? Emacs?) style of listing > modified files, [...] Not sure if you have already seen [1], but that style is to generate the change log file so that people can track the changes even if they do not have the VCS history (e.g., only the tarball is available). Listing touched files/functions in the commit message is recommended but not mandatory: [...] explicitly listing the files and functions that were changed is not strictly necessary, and in some cases (like identical mechanical changes in many places) even tedious. It is up to you to decide whether to allow your project’s developers to omit the list of changed files and functions from the log entries, and whether to allow such omissions under some specific conditions. The major benefits are listed in [1]. IMO it is not very important. [1] https://www.gnu.org/prep/standards/html_node/Change-Log-Concepts.html#Change-Log-Concepts _______________________________________________ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-leave@notmuchmail.org