On Mon, 26 Apr 2010 12:58:33 -0700, Dirk Hohndel <hohndel@infradead.org> wrote: > based on your comment on IRC I have rebased this patch to the current > origin/master and split it in two parts, one that makes the Received: header > special when getting headers from a message file, and one that changes the > heuristic by which we guess the best From: header. This passes the tests that > have been committed last week. Fantastic. All pushed. The test cases give me the freedom to rework the style of these patches as I want, for example to use talloc more to avoid lots of free (temporary); return result; And I can do that with the comfort of trusting the test suite to catch any mistakes I introduce. Whether otherwise, I would be less daring to touch it and would have pushed for more style changes before merging. -Carl -- carl.d.worth@intel.com