On Tue, 05 Jul 2011 02:00:33 +0200, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
> First, the customization interface for the custom sections (not the
> predefined ones) is very confusing. I was not able to use it at all.
> Instead I hacked the source code (see below) to add my section to the
> notmuch-hello-sections list.

What specifically did you find confusing? The first customization-option
is intended for sections like the all tags section which various
configuration options which should be explained by the docstrings next
to the options. The second item allows saved-searches-like sections.

By the way: Instead of editing the source directly, you can also put all
customizations like that in your configuration files and set
notmuch-hello-sections from there. Nevertheless your inbox-display
functions look useful in general so they should indeed be included.

> Second, when I tried to understand your patch, I found some names of
> functions and variables quite confusing. In the patch below, I tried to
> give them a better names and I also updated the documentation. Feel free
> to use my changes for your later patch submission.

Thanks, those look quite a bit clearer, naming things like that is
really not my strong suit. I'll include them in the next version of the
patch.

> 
> And last but not least, you allow quite wild modifications of tag
> searches (e.g. in notmuch-hello-generate-tag-alist), but is might be
> also useful to use such modifications for other searches. For example, I
> want to modify the saved searches in a similar way.
>  

Are you referring to things like specifying a filter for each tag or
count in saved-searches? My thinking was that since you specify each
item manually anyway, you can append any filter you might want to use
there. But I guess you're right that it's a bit more convenient to be
able to specify those once and not having to repeat it for each item.

> And here are my changes to your patch, which you might use as a
> suggestions for a next version of your patch. As I wrote above, it
> renames some functions and variables to more understandable names,
> updates documentation and adds a custom section for my personal use (I
> can live with this custom section in my .emacs if others do not like
> it).

If we add the same configuration options that
notmuch-hello-generate-tag-alist accepts, this section should be easy to
specify in your ~/.emacs with one or two lines anyway.

Cheers,
Daniel