Re: [PATCH v4 03/12] cli: add insert command

Subject: Re: [PATCH v4 03/12] cli: add insert command

Date: Tue, 05 Mar 2013 21:13:23 -0400

To: Peter Wang, notmuch@notmuchmail.org

Cc:

From: David Bremner

Peter Wang <novalazy@gmail.com> writes:

> The notmuch insert command reads a message from standard input,
> writes it to a Maildir folder, and then incorporates the message into
> the notmuch database.  Essentially it moves the functionality of
> notmuch-deliver into notmuch.

The first three patches in this series look OK to me so far.

There is some conflict with Jani's --config command line argument patches,
but that should be easy/generic to fix.

I'll try to review the next 3 patches in this series this week; this
message should serve as a heads up for people interested in this series
that its next on my agenda after Jani's config file patches.

• Previous message (by thread): Re: [PATCH v4 06/12] test: add tests for insert

Thread:

• Peter Wang—[PATCH v4 00/12] insert command [inbox, unread]
  • Peter Wang—[PATCH v4 01/12] tag-util: move out 'tag' command-line checks [inbox, notmuch::obsolete, notmuch::patch, notmuch::stale, unread]
    • Jani Nikula—Re: [PATCH v4 01/12] tag-util: move out 'tag' command-line checks [inbox, unread]
  • Peter Wang—[PATCH v4 02/12] tag-util: do not reset list in parse_tag_command_line [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Peter Wang—[PATCH v4 03/12] cli: add insert command [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH v4 03/12] cli: add insert command [inbox, unread]
  • Peter Wang—[PATCH v4 04/12] man: document 'insert' command [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH v4 04/12] man: document 'insert' command [inbox, unread]
  • Peter Wang—[PATCH v4 05/12] man: reference notmuch-insert.1 [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Peter Wang—[PATCH v4 06/12] test: add tests for insert [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH v4 06/12] test: add tests for insert [inbox, unread]
      • Peter Wang—Re: [PATCH v4 06/12] test: add tests for insert [inbox, unread]
        • Jani Nikula—Re: [PATCH v4 06/12] test: add tests for insert [inbox, unread]
  • Peter Wang—[PATCH v4 07/12] insert: add --folder option [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Peter Wang—[PATCH v4 08/12] man: document insert --folder option [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Peter Wang—[PATCH v4 09/12] test: test insert --folder option [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Peter Wang—[PATCH v4 10/12] insert: add --create-folder option [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Peter Wang—[PATCH v4 11/12] man: document insert --create-folder [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Peter Wang—[PATCH v4 12/12] test: test insert --create-folder option [inbox, notmuch::obsolete, notmuch::patch, unread]