Re: [PATCH] lib/message-file: close stream in destructor

Subject: Re: [PATCH] lib/message-file: close stream in destructor

Date: Thu, 09 May 2019 22:42:13 -0300

To: Will Dietz, notmuch@notmuchmail.org

Cc:

From: David Bremner


Will Dietz <w@wdtz.org> writes:

> Great, thank you!
>
> Much appreciated, I actually was running into this yesterday.
>
> ( which for whatever reason led to posting this on the subject:
> https://github.com/afewmail/afew/issues/193#issuecomment-490766850 )
>
> Would the valgrind support in the test suite catch this sort of thing
> (fd leak on relatively common path)?
>

Good question. It didn't in a naive test I tried (just running notmuch
new under valgrind --track-fds). This is probably has to do with glib
cleaning up the relevant objects during shutdown.
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Thread: