Re: [notmuch] [PATCH -v6] notmuch.el: Add face support to search mode

Subject: Re: [notmuch] [PATCH -v6] notmuch.el: Add face support to search mode

Date: Fri, 27 Nov 2009 22:56:20 -0800

To: Aneesh Kumar K.V

Cc: notmuch@notmuchmail.org

From: Carl Worth


On Sat, 28 Nov 2009 11:37:05 +0530, "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> wrote:
> This patch use notmuch-tag-face showing tags in the
> notmuch-search-mode.

Thanks, Aneesh! Your patience has prevailed again and I've pushed out
this patch.

> We can selectively highlight each tag by setting notmuch-tag-face-alist as below
> 
> (defface notmuch-tag-unread-face
>  '((((class color)) (:foreground "goldenrod")))
>   "Notmuch search mode face used to highligh tags.")
> 
> (defface notmuch-tag-inbox-face
>  '((((class color)) (:foreground "red")))
>   "Notmuch search mode face used to highligh tags.")
> 
> (setq notmuch-tag-face-alist '(("unread" . 'notmuch-tag-unread-face)
> 			       ("inbox" . 'notmuch-tag-inbox-face)))

I'm a bit concerned that this documentation is going to just disappear
in the commit log and not be where people might actually look for
it. You've got the beginnings of the documentation here:

> +(defvar notmuch-tag-face-alist nil
> +  "List containing the tag list that need to be highlighed")

Which could be expanded to include basically the example above.

Anyway, thanks for the patch.

-Carl
part-000.sig (application/pgp-signature)

Thread: