Re: [PATCH 1/2] new: Don't update DB mtime if FS mtime equals wall-clock time.

Subject: Re: [PATCH 1/2] new: Don't update DB mtime if FS mtime equals wall-clock time.

Date: Wed, 29 Jun 2011 15:35:33 -0700

To: Austin Clements, notmuch@notmuchmail.org

Cc: amdragon@mit.edu

From: Carl Worth


On Wed, 29 Jun 2011 03:10:54 -0400, Austin Clements <amdragon@MIT.EDU> wrote:
> This fixes a race where multiple message deliveries in the same second
> with an intervening notmuch new could result in messages being ignored
> by notmuch (at least, until a later delivery forced a rescan).

Excellent fix, Austin.

I've merged this, (and the following commit to drop the ugly
increment_mtime).

I think that even fixes an outstanding portability bug (where someone
previously sent patches to change our implementation of
increment_mtime).

It's sure nice to see notmuch become more robust all the time.

-Carl

-- 
carl.d.worth@intel.com
part-000.sig (application/pgp-signature)

Thread: