Re: [PATCH] emacs: Fix to unconditionally display subject changes in collapsed thread view

Subject: Re: [PATCH] emacs: Fix to unconditionally display subject changes in collapsed thread view

Date: Fri, 01 Jul 2011 02:06:44 -0700

To: notmuch@notmuchmail.org

Cc: David Bremner

From: Carl Worth


On Fri,  1 Jul 2011 02:01:08 -0700, Carl Worth <cworth@cworth.org> wrote:
> Rather than fixing the name of the variable and changing its default
> value, here we remove the condition entirely, such that the feature is
> enabled unconditionally.

I've just pushed this change out.

I emailed it here just to be able to comment on it.

David, I implemented this fix while writing up the NEWS[*] notes for the
0.6 release (and noticing that this feature which was implemented wasn't
actually usable as documented so I couldn't really add a NEWS item for
it).

If you want to sneak it into 0.6 I think it's safe, (it even hits one
existing test case---though an additional test case to show an actual
subject change appearing would be even better).

It's your call of course, and if the change doesn't go, then that's fine
too. In that case, I'll just not comment on this feature in NEWS until
our next release.

-Carl

[*] Yes, I'm working away at this—almost done now...
part-000.sig (application/pgp-signature)

Thread: