Re:

Subject: Re:

Date: Sun, 16 Oct 2011 20:25:38 -0300

To: Thomas Schwinge

Cc: notmuch@notmuchmail.org

From: David Bremner

On Sun, 16 Oct 2011 22:34:29 +0200, Thomas Schwinge <thomas@schwinge.name> wrote:

> Having worked in the same area ;-), I felt competent to review this.  And
> I definitely do like David's approach.  The patches look good, with the
> following comments:

Thanks for the review.  I pushed a modified version of the series which
I think fixed all of the things you noticed.

d

• Previous message (by thread): Re:

Thread:

• David Bremner—output file argument to notmuch dump. [inbox, notmuch::pushed, signed, unread]
  • Dmitry Kurochkin—Re: output file argument to notmuch dump. [inbox, notmuch::pushed, unread]
    • David Bremner—Re: output file argument to notmuch dump. [inbox, notmuch::pushed, signed, unread]
      • Tom Prince—Re: output file argument to notmuch dump. [inbox, notmuch::pushed, unread]
  • Jameson Graef Rollins—Re: output file argument to notmuch dump. [inbox, notmuch::pushed, signed, unread]
  • Jesse Rosenthal—Re: output file argument to notmuch dump. [inbox, notmuch::pushed, unread]
    • Tomi Ollila—Re: output file argument to notmuch dump. [inbox, notmuch::pushed, unread]
      • Jameson Graef Rollins—Re: output file argument to notmuch dump. [inbox, notmuch::pushed, signed, unread]
        • Tomi Ollila—Re: output file argument to notmuch dump. [inbox, notmuch::pushed, unread]
  • David Bremner—Re: output file argument to notmuch dump. [inbox, notmuch::pushed, signed, unread]
    • david@tethera.net— [inbox, notmuch::pushed, unread]
      • david@tethera.net—[PATCH 1/6] test: update dump-restore to use redirection instead of filename args [inbox, notmuch::patch, notmuch::pushed, unread]
      • david@tethera.net—[PATCH 2/6] test: add tests for command line arguments to notmuch-dump [inbox, notmuch::patch, notmuch::pushed, unread]
      • david@tethera.net—[PATCH 3/6] notmuch-dump: update handling of file name argument [inbox, notmuch::patch, notmuch::pushed, unread]
      • david@tethera.net—[PATCH 4/6] notmuch-dump: treat any remaining arguments after the filename as search terms [inbox, notmuch::patch, notmuch::pushed, unread]
      • david@tethera.net—[PATCH 5/6] test: all dump-restore tests should be working now [inbox, notmuch::patch, notmuch::pushed, unread]
      • david@tethera.net—[PATCH 6/6] notmuch-dump: deprecate use of output file argument. [inbox, notmuch::patch, notmuch::pushed, unread]
      • Thomas Schwinge—Re: [inbox, notmuch::review, signed, unread]
        • David Bremner—Re: [inbox, notmuch::pushed, unread]
    • Tomi Ollila—Re: output file argument to notmuch dump. [inbox, notmuch::pushed, unread]
      • David Bremner—Re: output file argument to notmuch dump. [inbox, notmuch::pushed, signed, unread]
    • Jameson Graef Rollins—Re: output file argument to notmuch dump. [inbox, notmuch::pushed, signed, unread]
      • David Bremner—Re: output file argument to notmuch dump. [inbox, notmuch::pushed, unread]