Re: [PATCH 4/6] cli: intialize crypto structure in show and reply

Subject: Re: [PATCH 4/6] cli: intialize crypto structure in show and reply

Date: Thu, 17 May 2012 13:53:12 -0700

To: Jani Nikula

Cc: Notmuch Mail

From: Jameson Graef Rollins

On Thu, May 17 2012, Jani Nikula <jani@nikula.org> wrote:
> In short, when you read enough code, having everything explicitly
> stated becomes a burden. It's explicit, but you have to read it all,
> even when there really is no need to.

Not everyone who reads the code is an expert.  I think it's important
for the code to be clear to everyone.  Experts can more easily gloss
over the trivial parts than novices can divine things that are hidden.

jamie.

• Previous message (by thread): Re: [PATCH 4/6] cli: intialize crypto structure in show and reply

Thread:

• Jameson Graef Rollins—[PATCH 0/6] cli: improve handling of crypto parameters contexts [inbox, unread]
  • Jameson Graef Rollins—[PATCH 1/6] cli: new crypto structure to store crypto contexts and parameters [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Jameson Graef Rollins—[PATCH 2/6] cli: modify mime_node_context to use the new notmuch_crypto_t [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Jameson Graef Rollins—[PATCH 3/6] cli: modify mime_node_open to take crypto struct as argument [inbox, notmuch::obsolete, notmuch::patch, unread]
        • Jameson Graef Rollins—[PATCH 4/6] cli: intialize crypto structure in show and reply [inbox, notmuch::obsolete, notmuch::patch, unread]
          • Jameson Graef Rollins—[PATCH 5/6] cli: new crypto verify flag to handle verification [inbox, notmuch::obsolete, notmuch::patch, unread]
            • Jameson Graef Rollins—[PATCH 6/6] cli: lazily create the crypto gpg context only when needed [inbox, notmuch::obsolete, notmuch::patch, unread]
              • Austin Clements—Re: [PATCH 6/6] cli: lazily create the crypto gpg context only when needed [inbox, notmuch::review, unread]
          • Jani Nikula—Re: [PATCH 4/6] cli: intialize crypto structure in show and reply [inbox, notmuch::review, unread]
            • Jameson Graef Rollins—Re: [PATCH 4/6] cli: intialize crypto structure in show and reply [inbox, signed, unread]
              • Jani Nikula—Re: [PATCH 4/6] cli: intialize crypto structure in show and reply [inbox, unread]
                • Jameson Graef Rollins—Re: [PATCH 4/6] cli: intialize crypto structure in show and reply [inbox, signed, unread]
                  • Jani Nikula—Re: [PATCH 4/6] cli: intialize crypto structure in show and reply [inbox, unread]
                    • Jameson Graef Rollins—Re: [PATCH 4/6] cli: intialize crypto structure in show and reply [inbox, signed, unread]
                  • Daniel Kahn Gillmor—Re: [PATCH 4/6] cli: intialize crypto structure in show and reply [inbox, signed, unread]
                    • Tomi Ollila—Re: [PATCH 4/6] cli: intialize crypto structure in show and reply [inbox, unread]
                    • Jani Nikula—Re: [PATCH 4/6] cli: intialize crypto structure in show and reply [inbox, unread]
                      • Daniel Kahn Gillmor—Re: [PATCH 4/6] cli: intialize crypto structure in show and reply [inbox, signed, unread]
          • Austin Clements—Re: [PATCH 4/6] cli: intialize crypto structure in show and reply [inbox, notmuch::review, unread]
        • Jani Nikula—Re: [PATCH 3/6] cli: modify mime_node_open to take crypto struct as argument [inbox, notmuch::review, unread]
        • Austin Clements—Re: [PATCH 3/6] cli: modify mime_node_open to take crypto struct as argument [inbox, notmuch::review, unread]
      • Jani Nikula—Re: [PATCH 2/6] cli: modify mime_node_context to use the new notmuch_crypto_t [inbox, notmuch::review, unread]
    • Jani Nikula—Re: [PATCH 1/6] cli: new crypto structure to store crypto contexts and parameters [inbox, notmuch::review, unread]