On Thu 07 Jan 2021 at 17:09 +0000, Michael J. Gruber wrote: > As for the series: the notmuch based MUA "alot" switched to the new > python bindings recently. collect_tags() is something I used in a > feature PR submitted but not merged yet there (while on the old bindings), > and in my updated feature PR there I directly roll > notmuch2._tags.ImmutableTagSet(msgs, '_iter_p', notmuch2.capi.lib.notmuch_messages_collect_tags). You could do this entirely in the public bindings too could you not? Something like (untested): def collect_tags(db, query): tags = set() for msg in db.messages(query): tags.update(msg.tags) anyway, i guess the internal APIs you use won't change before your patchset here lands so this doesn't matter much. > I don't know whether this will land in alot, but feature parity of the > new bindings with the old ones is a good aim Thanks for contributing this! I never aimed for full parity because I didn't feel like making the API decisions for APIs I had no need to use myself. But it's great when people needing things can add it! Cheers, Floris _______________________________________________ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-leave@notmuchmail.org