Re: [PATCH] improve notmuch-hello layout

Subject: Re: [PATCH] improve notmuch-hello layout

Date: Sun, 09 Jul 2023 14:57:07 -0300

To: Rudolf Adamkovič, notmuch@notmuchmail.org

Cc:

From: David Bremner


Rudolf Adamkovič <salutis@me.com> writes:
>
> Rudy
> From 278017d06bb986f4ec99118bfcfdec8dab970f2b Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= <salutis@me.com>
> Date: Thu, 25 May 2023 16:22:08 +0200
> Subject: [PATCH 1/2] emacs: fix notmuch-hello layout when
>  display-line-numbers-mode is on
>
> ---
>  emacs/notmuch-hello.el | 25 +++++++++++++++++++------
>  1 file changed, 19 insertions(+), 6 deletions(-)
>
> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
> index 4662e704..3235f555 100644
> --- a/emacs/notmuch-hello.el
> +++ b/emacs/notmuch-hello.el
> @@ -412,6 +412,7 @@ supported for \"Customized queries section\" items."
>  (defun notmuch-search-item-field-width ()
>    (max 8 ; Don't let the search boxes be less than 8 characters wide.
>         (- (window-width)
> +	  (line-number-display-width)

This seems like a harmless change, except that we claim to support emacs
25.1. The function #'line-number-display-width is apparently from emacs
26.1. I don't honestly know if the code even works in emacs 25 anymore,
perhaps we should bump the minimum version requirement. Or you could
make this change conditional on version somehow. The fact that you have
to update 7 places in the code makes me wonder if the calculation should
be collected into a function, so that the next change can be done more easily.
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: