Re: [notmuch] [PATCH] Prevent data loss caused by SIGINT during notmuch new

Subject: Re: [notmuch] [PATCH] Prevent data loss caused by SIGINT during notmuch new

Date: Tue, 13 Apr 2010 08:47:04 -0700

To: Michal Sojka, notmuch@notmuchmail.org

Cc:

From: Carl Worth


On Tue, 30 Mar 2010 10:23:23 +0200, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
> When Ctrl-C is pressed in a wrong time during notmuch new, it can lead
> to removal of messages from the database even if the files were not
> removed.
> 
> It happened at least once to me.
> 
> Signed-off-by: Michal Sojka <sojkam1@fel.cvut.cz>

Thanks so much, Michal!

This was a very bad bug that I'm sure I introduced myself when
implementing rename support.

Thanks to Sebastian for reminding me to pick this up for the 0.2
release.

And, everyone, if I'm behind on patches, (which has always been the case
so far with this project...), please feel free to make plenty of noise
when there are known fixes for data-loss bugs. We really shouldn't let
those sit for a couple of weeks!

-Carl
part-000.sig (application/pgp-signature)

Thread: